Drop Python 3.8, add Python 3.11 to CI and run pyupgrade#650
Merged
ccordoba12 merged 6 commits intopython-lsp:developfrom May 28, 2025
Merged
Drop Python 3.8, add Python 3.11 to CI and run pyupgrade#650ccordoba12 merged 6 commits intopython-lsp:developfrom
pyupgrade#650ccordoba12 merged 6 commits intopython-lsp:developfrom
Conversation
dalthviz
reviewed
May 28, 2025
Contributor
There was a problem hiding this comment.
Thank you @krassowski for helping with this! Left a suggestion to fix what seems to be a typo in the requires-python definition update (a 0 instead of a 9) but other than that this looks good 👍
Just in case, what do you think @ccordoba12 ?
Edit: Also updated the PR title and description to reflect that the version being dropped is actually Python 3.8
dalthviz
changed the title
pyupgradepyupgrade
ccordoba12
changed the title
pyupgradepyupgrade
ccordoba12
approved these changes
May 28, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @krassowski!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyupgrade